Skip to content

Conversation

@YellowLime77
Copy link

@YellowLime77 YellowLime77 commented Aug 8, 2024

Fixes #75
Fixes #69

Original color: #0f766e (same as text color, causing issues)
Replacement color: #f0fffb

Replacement color was chosen compared to the lara-light-blue theme (not sure if this method is okay): In HSL, H is 10 less than text color, S & L are the same as lara-light-blue's S & L.

Original color: #0f766e (same as text color, causing issues)
Replacement color: #f0fffb

Replacement color was chosen compared to the lara-light-blue theme (not sure if this method is okay): In HSL, H is 10 less than text color, S & L are the same as lara-light-blue's S & L.
@melloware
Copy link
Member

@YellowLime77 can you add Fix #69 too so it links this PR to that ticket as well.

@YellowLime77
Copy link
Author

Already done

@Lerwox
Copy link

Lerwox commented Nov 15, 2024

Hello, is there a date planned for the merge of this feature?
btw I checked on the angular version, and the background seems to be #f0fdfa source

@MartinNiederl
Copy link

This still isn't merged yet. Are there any updates?

$primaryTextColor: #ffffff !default;

$highlightBg: #0f766e !default;
$highlightBg: #f0fffb !default;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, I think the color should be this, sourced from the primeuix repo and the latest color palette!

#f0fdfa

https://github.com/primefaces/primeuix/blob/4cd80750aa2850690b7942d72d180ec8c4efaa49/packages/themes/src/presets/lara/base/index.ts#L19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theme lara-light-teal: Highlight color is same as text color, causing readability issues Paginator style issue in lara-light-teal theme

5 participants